test for function with typeof not instanceof#51
Open
RamIdeas wants to merge 3 commits intotroch:masterfrom
Open
test for function with typeof not instanceof#51RamIdeas wants to merge 3 commits intotroch:masterfrom
typeof not instanceof#51RamIdeas wants to merge 3 commits intotroch:masterfrom
Conversation
allows environments (e.g. jest) to override the global Function constructor
using `constructor.name` rather than `instanceof`
rather than `instanceof RegExp`
|
This change would be great, currently preventing this package from use in next.js middleware since it disallows references to Function. This is probably also true for all edge functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows environments (e.g. jest) to override the global
FunctionconstructorChecking via
instanceofresolved to false, which caused the Path#source property to be set incorrectly wherepartialTestwould return{}rather thannullwhen it wasn't meant to matchEDIT: actually, not sure if it is
jestwhich is wrappingFunctionor the environment I am running my code in (Cloudflare Workers) which doesn't alloweval/new Function